Pass through TLB date metadata and invalidate loan balance cache#670
Closed
jforseth-figure wants to merge 2 commits into
Closed
Pass through TLB date metadata and invalidate loan balance cache#670jforseth-figure wants to merge 2 commits into
jforseth-figure wants to merge 2 commits into
Conversation
Surface asOfDate and dataStartDate on loan balance metrics and clear stale pulse_cache rows after go-pulse-service aggregation changes.
EasyEtHP4
reviewed
Jun 29, 2026
| @@ -0,0 +1,7 @@ | |||
| -- Invalidate cached Total Loan Balance metrics after aggregation logic change. | |||
| -- Cached entries will be rebuilt on next request with the updated go-pulse-service query. | |||
| DELETE FROM pulse_cache | |||
Contributor
There was a problem hiding this comment.
This deletes the entire history of these metrics. Are we sure that's what we want to do? If so, are we able to backfill and rebuild the history?
Contributor
Author
There was a problem hiding this comment.
This seems like it's definitely :badvibes: I should've caught.
But how should we handle the old data? Just leave it be and show a drop in TBL? Backfill using a different approach?
We can manually clear part of the cache as needed, but clearing everything is probably a bad idea.
EasyEtHP4
approved these changes
Jun 29, 2026
Contributor
Author
|
I don't think https://app.shortcut.com/figure/story/517316/update-tlb-to-exclude-loans-that-have-reached-end-of-term-incorporate-servicing-data-where-available-valon-update-to-include actually requires all this date wiring. :badvibes:, closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related PRs
Deploy order: go-pulse-service → explorer-service → pulse-service / frontend-provenance-pulse
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes